julian
d0841c8601
Replace the hardcoded role enum (admin/operator/cashier/readonly, checked
literally as requireRole("admin",...) across ~15 routes) with dynamic RBAC:
roles are DATA, route guards check a PERMISSION.
@parking/shared defines a code-defined grid: RESOURCES (user/role/tariff/
subscription/site/device/shift/payment/session/event/report) × Action
(create/read/update/delete + domain verbs void/cash) -> PERMISSIONS
(resource:action, e.g. tariff:update, payment:create, event:void).
DB: new roles + role_permissions tables; users.role enum -> role_id FK;
migration 0007_rbac (create tables, seed the builtin admin role + all 26
perms, seed operator/cashier/readonly composable roles matching old
behaviour, rebuild users to swap the column copying all rows).
auth.ts: JWT payload role -> roleId; permissionsFor(roleId) with an
in-memory cache + bumpPermsCache(); requirePermission(...perms) preHandler;
requireAuth for /me & /language; initAuth(db) wires the resolver once. Every
route guard mapped to a permission; device ingress (devices/qr-reader) stays
auth-free by design. New routes/users.ts (user:* CRUD, bcrypt 12, last-admin
guard) + routes/roles.ts (role:* CRUD, builtin-protected, perms validated
against the grid, cache bump on write). auth/me + /login return
{roleId, roleName, permissions, language}. seed-admin -> roleId:'admin'.
Frontend: SessionUser carries permissions + can() helper; router nav/route
guards gate by permission (requirePerm replaces adminOnly); SiteSettings
edit gated by site:update; new UsersManager + RolesManager (permission
checkbox grid; admin role locked); i18n nav.users/roles + blocks (sq+en).
Decisions: one role per user; protected built-in admin (no-lockout: the last
admin can't be deleted/downgraded); JWT carries roleId, perms resolved
per-request so role edits apply immediately (no re-login).
Verified: full build green; 20-assertion inject test passes (cashier 403s on
tariff publish + user list, admin passes, granting a perm applies on the next
request, last-admin + builtin-role protections return 409); migration 0007
applied to a copy of the live DB (incl WAL/shm) — existing admin maps to
role_id='admin', all rows preserved. Append-only event chain untouched
(event:void gates appending a void, not a delete).
Claude-Session: https://claude.ai/code/session_01Xcm6ikLgGoCxxHrxtjkk5V
22 lines
915 B
TypeScript
22 lines
915 B
TypeScript
import type { FastifyInstance } from "fastify";
|
|
import { requirePermission } from "../auth.js";
|
|
import type { DeviceMonitor } from "../device-monitor.js";
|
|
|
|
// Unified device-status snapshot for the booth footer. The DeviceMonitor polls all
|
|
// configured devices (relays/readers/cameras via healthCheck, printers via their
|
|
// rich readStatus) in the background; this exposes its cache. Live updates ride the
|
|
// booth WebSocket (kind:"device-status") — this REST route is the initial load /
|
|
// fallback. Any authenticated role may read (operational, not a setup action).
|
|
// See wiki/concepts/device-status-monitoring.md, booth-console.md.
|
|
|
|
export async function deviceStatusRoutes(
|
|
app: FastifyInstance,
|
|
monitor: DeviceMonitor,
|
|
): Promise<void> {
|
|
const guard = requirePermission("device:read");
|
|
|
|
app.get("/api/devices/status", { preHandler: guard }, async () => ({
|
|
devices: monitor.snapshot(),
|
|
}));
|
|
}
|