8129b63a8c
Self-service profile: any signed-in user edits their OWN fullName/email and changes their OWN password (proving the current one), without any user:* permission. New routes PUT /api/auth/profile + /api/auth/password act only on req.user.sub (cannot touch username/role), CSRF-guarded; SPA screen at /profile reachable from the header username chip. email added to the session view + SessionUser. 7 tests (routes/profile.test.ts); 148 server tests green. Desktop in CI: new .gitea/workflows/build-desktop.yml builds .deb + .AppImage on every push to dev/main and uploads them as unsigned workflow artifacts (per-commit test build). Signed/versioned release stays on release.yml (tag v*). Wiki: local-jwt-auth (self-service routes), desktop-shell-tauri (two-workflow CI split), log entry. Claude-Session: https://claude.ai/code/session_01Xcm6ikLgGoCxxHrxtjkk5V
222 lines
8.3 KiB
TypeScript
222 lines
8.3 KiB
TypeScript
import bcrypt from "bcrypt";
|
|
import type { FastifyInstance } from "fastify";
|
|
import { eq, roles, users, type Db } from "@parking/db";
|
|
import {
|
|
clearAuthCookies,
|
|
newCsrfToken,
|
|
permissionsFor,
|
|
requireAuth,
|
|
setAuthCookies,
|
|
} from "../auth.js";
|
|
|
|
// Local auth: username + bcrypt password → signed JWT in an HttpOnly cookie.
|
|
// Fully offline; no external identity provider. See wiki/entities/local-jwt-auth.md.
|
|
|
|
interface LoginBody {
|
|
username: string;
|
|
password: string;
|
|
}
|
|
|
|
const LANGS = ["sq", "en"] as const;
|
|
type Lang = (typeof LANGS)[number];
|
|
interface LanguageBody {
|
|
language: Lang;
|
|
}
|
|
|
|
const THEMES = ["dark", "light"] as const;
|
|
type Theme = (typeof THEMES)[number];
|
|
interface ThemeBody {
|
|
theme: Theme;
|
|
}
|
|
|
|
// Self-service profile: a signed-in user edits their OWN display name + email. This is
|
|
// NOT the admin user-management path (routes/users.ts) — it only ever touches the caller
|
|
// (req.user.sub), needs no `user:*` permission, and can't change username, role, or any
|
|
// other account. "" clears a field (→ null). See wiki/entities/local-jwt-auth.md.
|
|
interface ProfileBody {
|
|
fullName?: string | null;
|
|
email?: string | null;
|
|
}
|
|
|
|
// Self-service password change: the user proves they hold the CURRENT password before
|
|
// setting a new one — unlike the admin reset (users.ts), which sets it outright. This is
|
|
// why it lives here and not behind a permission: it's account-self-care, not admin power.
|
|
interface PasswordBody {
|
|
currentPassword: string;
|
|
newPassword: string;
|
|
}
|
|
|
|
const MIN_PASSWORD = 8;
|
|
|
|
/** Trim a self-service profile string; "" (or whitespace) → null (clear the field).
|
|
* Returns undefined for an absent key so an update only touches what was sent. */
|
|
function cleanProfileField(v: string | null | undefined): string | null | undefined {
|
|
if (v === undefined) return undefined;
|
|
const trimmed = typeof v === "string" ? v.trim() : "";
|
|
return trimmed === "" ? null : trimmed;
|
|
}
|
|
|
|
/** The session shape the SPA bootstraps from: identity + role + its permission
|
|
* list (so the UI can gate nav/routes) + language. Role NAME is for display; the
|
|
* permissions are the source of truth. */
|
|
function sessionView(
|
|
db: Db,
|
|
user: {
|
|
id: string;
|
|
username: string;
|
|
roleId: string;
|
|
language: string;
|
|
theme: string;
|
|
fullName?: string | null;
|
|
email?: string | null;
|
|
},
|
|
) {
|
|
const role = db.select().from(roles).where(eq(roles.id, user.roleId)).get();
|
|
const permissions = [...permissionsFor(user.roleId)];
|
|
return {
|
|
id: user.id,
|
|
username: user.username,
|
|
roleId: user.roleId,
|
|
roleName: role?.name ?? user.roleId,
|
|
permissions,
|
|
language: user.language,
|
|
theme: user.theme,
|
|
fullName: user.fullName ?? null,
|
|
email: user.email ?? null,
|
|
};
|
|
}
|
|
|
|
export async function authRoutes(app: FastifyInstance, db: Db): Promise<void> {
|
|
app.post<{ Body: LoginBody }>("/api/auth/login", async (req, reply) => {
|
|
const { username, password } = req.body ?? {};
|
|
if (!username || !password) {
|
|
return reply.code(400).send({ error: "username and password required" });
|
|
}
|
|
|
|
const user = await db.select().from(users).where(eq(users.username, username)).get();
|
|
|
|
// Always run a bcrypt compare to avoid leaking which usernames exist (timing).
|
|
const hash = user?.passwordHash ?? "$2b$10$invalidinvalidinvalidinvalidinvalidinvalidinv";
|
|
const ok = await bcrypt.compare(password, hash);
|
|
// A soft-deleted user (in the recycle bin) cannot log in — treat as invalid, with no
|
|
// distinct error so a deleted account isn't enumerable.
|
|
if (!user || !ok || user.deletedAt) {
|
|
return reply.code(401).send({ error: "invalid credentials" });
|
|
}
|
|
|
|
const csrf = newCsrfToken();
|
|
// No expiresIn: the token is valid until explicit logout (see auth.ts). The
|
|
// token carries roleId (not the permission list) — perms resolve per-request,
|
|
// so a role edit applies immediately with no re-login.
|
|
const token = await reply.jwtSign({
|
|
sub: user.id,
|
|
username: user.username,
|
|
roleId: user.roleId,
|
|
csrf,
|
|
});
|
|
setAuthCookies(reply, token, csrf);
|
|
// `language` is NOT in the JWT (identity/role only) — it's a mutable preference
|
|
// read from the DB, so changing it needs no token refresh.
|
|
return sessionView(db, user);
|
|
});
|
|
|
|
app.post("/api/auth/logout", async (_req, reply) => {
|
|
clearAuthCookies(reply);
|
|
return { ok: true };
|
|
});
|
|
|
|
// Who am I — used by the SPA to bootstrap session state on load. Reads the live
|
|
// `language` preference from the DB (not the token).
|
|
app.get(
|
|
"/api/auth/me",
|
|
{ preHandler: requireAuth },
|
|
async (req, reply) => {
|
|
const row = await db.select().from(users).where(eq(users.id, req.user.sub)).get();
|
|
if (!row) {
|
|
// The user was deleted while their cookie was still valid — clear it.
|
|
clearAuthCookies(reply);
|
|
return reply.code(401).send({ error: "session no longer valid" });
|
|
}
|
|
return sessionView(db, row);
|
|
},
|
|
);
|
|
|
|
// Change MY own UI language preference (any signed-in user). Persisted to the
|
|
// users row so it's restored on the next login, from any booth. See i18n.md.
|
|
app.put<{ Body: LanguageBody }>(
|
|
"/api/auth/language",
|
|
{ preHandler: requireAuth },
|
|
async (req, reply) => {
|
|
const language = req.body?.language;
|
|
if (!language || !LANGS.includes(language)) {
|
|
return reply.code(400).send({ error: `language must be one of: ${LANGS.join(", ")}` });
|
|
}
|
|
await db.update(users).set({ language }).where(eq(users.id, req.user.sub)).run();
|
|
return { language };
|
|
},
|
|
);
|
|
|
|
// Change MY own UI theme preference (any signed-in user). Persisted to the users
|
|
// row like `language`, so it's restored on the next login from any booth.
|
|
app.put<{ Body: ThemeBody }>(
|
|
"/api/auth/theme",
|
|
{ preHandler: requireAuth },
|
|
async (req, reply) => {
|
|
const theme = req.body?.theme;
|
|
if (!theme || !THEMES.includes(theme)) {
|
|
return reply.code(400).send({ error: `theme must be one of: ${THEMES.join(", ")}` });
|
|
}
|
|
await db.update(users).set({ theme }).where(eq(users.id, req.user.sub)).run();
|
|
return { theme };
|
|
},
|
|
);
|
|
|
|
// Edit MY own display name / email (any signed-in user; no permission needed — it only
|
|
// touches the caller). Cannot change username or role — those stay admin-only (users.ts).
|
|
app.put<{ Body: ProfileBody }>(
|
|
"/api/auth/profile",
|
|
{ preHandler: requireAuth },
|
|
async (req, reply) => {
|
|
const fullName = cleanProfileField(req.body?.fullName);
|
|
const email = cleanProfileField(req.body?.email);
|
|
const patch: Record<string, string | null> = {};
|
|
if (fullName !== undefined) patch.fullName = fullName;
|
|
if (email !== undefined) patch.email = email;
|
|
if (Object.keys(patch).length === 0) {
|
|
return reply.code(400).send({ error: "nothing to update" });
|
|
}
|
|
await db.update(users).set(patch).where(eq(users.id, req.user.sub)).run();
|
|
const row = await db.select().from(users).where(eq(users.id, req.user.sub)).get();
|
|
if (!row) return reply.code(401).send({ error: "session no longer valid" });
|
|
return sessionView(db, row);
|
|
},
|
|
);
|
|
|
|
// Change MY own password — must prove the CURRENT one first (defends against a walked-up,
|
|
// already-logged-in booth: a passerby can't silently re-key the account). New password
|
|
// >= MIN_PASSWORD. Distinct from the admin reset (users.ts), which needs no current pw.
|
|
app.put<{ Body: PasswordBody }>(
|
|
"/api/auth/password",
|
|
{ preHandler: requireAuth },
|
|
async (req, reply) => {
|
|
const currentPassword = req.body?.currentPassword ?? "";
|
|
const newPassword = req.body?.newPassword ?? "";
|
|
if (newPassword.length < MIN_PASSWORD) {
|
|
return reply.code(400).send({ error: `password must be at least ${MIN_PASSWORD} characters` });
|
|
}
|
|
const row = await db.select().from(users).where(eq(users.id, req.user.sub)).get();
|
|
if (!row) {
|
|
clearAuthCookies(reply);
|
|
return reply.code(401).send({ error: "session no longer valid" });
|
|
}
|
|
const ok = await bcrypt.compare(currentPassword, row.passwordHash);
|
|
if (!ok) {
|
|
return reply.code(403).send({ error: "current password is incorrect" });
|
|
}
|
|
const passwordHash = await bcrypt.hash(newPassword, 12);
|
|
await db.update(users).set({ passwordHash }).where(eq(users.id, req.user.sub)).run();
|
|
return { ok: true };
|
|
},
|
|
);
|
|
}
|