trm/processor
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fill in commit SHA for Phase 1 tasks 1.5-1.8 in ROADMAP and task files

Browse Source
This commit is contained in:
Julian Çuni
2026-04-30 21:47:53 +02:00
parent 2a50aaf175
commit 4686a9c391
5 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.planning/phase-1-throughput/07-position-writer.md
+1 -1
View File
@@ -91,6 +91,6 @@ If a transaction-wide failure occurs (Pool dead, transient network), all records
## Done
`src/core/writer.ts` — multi-row INSERT with RETURNING, duplicate detection by (device_id, ts) set diff, sequential chunking, bigint/Buffer attribute serialization (handles Buffer.toJSON shape). `test/writer.test.ts` — 14 tests covering happy path, all-duplicate, mixed, pool error, chunk split, Buffer base64, bigint string, parameter ordering, metrics. *(pending commit SHA)*
`src/core/writer.ts` — multi-row INSERT with RETURNING, duplicate detection by (device_id, ts) set diff, sequential chunking, bigint/Buffer attribute serialization (handles Buffer.toJSON shape). `test/writer.test.ts` — 14 tests covering happy path, all-duplicate, mixed, pool error, chunk split, Buffer base64, bigint string, parameter ordering, metrics. Landed in `68d3da3`.
**Note:** The spec's `RETURNING (xmax = 0) AS inserted` idiom was replaced with a simpler set-difference approach — compare RETURNING rows against input by (device_id, ts). The xmax approach is mentioned in the spec but then immediately qualified: "rows that hit the conflict are NOT returned." The set-diff is cleaner and avoids confusion. The spec's own Note section confirms this is the right approach.